Put the configuration item description into the configuration file and fix the bug where the heartbeat still reports plugin information after the plugin is uninstalled. #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1324 +/- ##
=============================================
- Coverage 42.67% 42.67% -0.01%
Complexity 3289 3289
=============================================
Files 823 823
Lines 18299 18303 +4
Branches 2014 2014
=============================================
Hits 7810 7810
- Misses 9513 9517 +4
Partials 976 976
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
luanwenfei-venus
added
area/framework
daizhenyu
reviewed
Sep 28, 2023
...ore-core/src/main/java/com/huaweicloud/sermant/core/plugin/common/PluginSchemaValidator.java
Show resolved
Hide resolved
TangLeDaily
reviewed
Sep 28, 2023
sermant-agentcore/sermant-agentcore-config/config/config.properties
Outdated
Show resolved
Hide resolved
sermant-agentcore/sermant-agentcore-config/config/config.properties
Outdated
Show resolved
Hide resolved
luanwenfei-venus
force-pushed
the
develop_issue_1323
branch
from
d449686
to
f51e14f
Compare
daizhenyu
approved these changes
Sep 28, 2023
TangLeDaily
approved these changes
Sep 28, 2023
kkf1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1323
[Modification content] 1. Add configuration description to the configuration file 2. Fix the bug where the heartbeat still reports plug-in information after the plug-in is uninstalled
[Use case description] Not involved
[Self-test situation] 1. The static check has been cleared. 2. The self-verification has passed. After the plug-in is uninstalled, it will be cleared in the Sermant Backend plug-in display area.
[Scope of Impact] 1. The configuration description has been deleted from the official document. The configuration file shall be subject to the configuration in the project file.