Supports repeated installation of plugins, using '#' to separate plugin copies, plugin services and configured Key information to carry class loaders #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luanwenfei-venus
added
kind/enhancement
luanwenfei-venus
force-pushed
the
develop_issue_1332_enhancement
branch
2 times, most recently
from
19557eb
to
cdc1f25
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1335 +/- ##
=============================================
- Coverage 42.29% 42.24% -0.05%
+ Complexity 3274 3272 -2
=============================================
Files 823 824 +1
Lines 18303 18309 +6
Branches 2017 2017
=============================================
- Hits 7741 7735 -6
- Misses 9588 9601 +13
+ Partials 974 973 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
lilai23
reviewed
Oct 19, 2023
...tcore-core/src/main/java/com/huaweicloud/sermant/core/plugin/config/PluginConfigManager.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Oct 19, 2023
.../sermant-agentcore-core/src/main/java/com/huaweicloud/sermant/core/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
lilai23
reviewed
Oct 19, 2023
...ore-core/src/main/java/com/huaweicloud/sermant/core/plugin/service/PluginServiceManager.java
Outdated
Show resolved
Hide resolved
luanwenfei-venus
force-pushed
the
develop_issue_1332_enhancement
branch
from
cdc1f25
to
d4abf4a
Compare
luanwenfei-venus
force-pushed
the
develop_issue_1332_enhancement
branch
from
d4abf4a
to
fb279c6
Compare
hanbingleixue
approved these changes
Oct 20, 2023
lilai23
approved these changes
Oct 26, 2023
kkf1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【Fix issue】#1332
[Modified content] 1. Modified the way the plug-in manager obtains the plug-in directory when installing plug-ins, and truncated the plug-in name through the copy separator 2. Modified the method of plug-in service manager to identify plug-in services, adding a new class loader to the identification content 3 , Modified the method of plug-in configuration manager to identify plug-in configuration, and added a new class loader to the identification content.
[Use case description] New use case 1. Static installation of multi-copy plug-ins 2. Dynamic installation of multi-copy plug-ins 3. Install copy plug-ins to test plug-in service differentiation 4. Install copy plug-ins to test plug-in configuration differentiation 5. Install copy plug-ins to test bytecode capabilities Take effect
[Self-test situation] 1. The local static check has passed; 2. Baseline use case integration test, new use cases are manually covered
[Scope of impact] 1. Is there any impact on users' use (such as API modifications and startup parameter modifications)? 2. Is it necessary to update some documents (such as user manuals)