Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that host classes could be loaded from the plugin class loader. #1356

Merged

Conversation

luanwenfei-venus
Copy link
Collaborator

@luanwenfei-venus luanwenfei-venus commented Nov 6, 2023

【Fix issue】#1352

[Modification content] 1. Added the plug-in class loader to load from itself first. 2. Modified the cache field name for plug-in service class loading.

[Use case description] Not involved

[Self-test situation] 1. The local static check has been cleared; 2. The threshold use case passed

[Scope of influence] Not involved

@luanwenfei-venus luanwenfei-venus added kind/bug Something isn't working area/framework Issues or PRs releated to sermant core service labels Nov 6, 2023
@luanwenfei-venus luanwenfei-venus self-assigned this Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (e103574) 42.83% compared to head (c9b536d) 42.76%.

Additional details and impacted files
@@             Coverage Diff              @@
##              1.2.x    #1356      +/-   ##
============================================
- Coverage     42.83%   42.76%   -0.07%     
+ Complexity     3301     3298       -3     
============================================
  Files           824      824              
  Lines         18311    18322      +11     
  Branches       2015     2017       +2     
============================================
- Hits           7844     7836       -8     
- Misses         9484     9504      +20     
+ Partials        983      982       -1     
Flag Coverage Δ
unittests 42.76% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...nt/core/plugin/classloader/ServiceClassLoader.java 0.00% <0.00%> (ø)
...ant/core/plugin/classloader/PluginClassLoader.java 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sherlockhan Sherlockhan merged commit ef00d75 into sermant-io:1.2.x Nov 8, 2023
70 checks passed
@kkf1 kkf1 changed the title 修复可以从插件类加载器中加载到宿主类的问题 Fixed bug where host classes could be loaded from the plugin class loader. Apr 13, 2024
@kkf1 kkf1 changed the title Fixed bug where host classes could be loaded from the plugin class loader. Fixed bug that host classes could be loaded from the plugin class loader. Apr 13, 2024
@kkf1 kkf1 changed the title Fixed bug that host classes could be loaded from the plugin class loader. Fix bug that host classes could be loaded from the plugin class loader. Apr 13, 2024
@kkf1 kkf1 changed the title Fix bug that host classes could be loaded from the plugin class loader. Fix the bug that host classes could be loaded from the plugin class loader. Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/framework Issues or PRs releated to sermant core service kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants