Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs bug fix. #1382

Closed
wants to merge 1 commit into from
Closed

Conversation

TangLeDaily
Copy link
Collaborator

@TangLeDaily TangLeDaily commented Dec 6, 2023

【Fix issue】#1381

【Modified content】

  1. Modified the initialization timing of defaultLogger in LoggerFactory
  2. Modified the text description of log printing in PluginClassLoader

[Use case description] No
[Self-test situation] 1. Local static check passed;

[Scope of influence] None

Signed-off-by: TLPC <470193496@qq.com>
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (86189df) 42.74% compared to head (b834de2) 42.61%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...ant/core/plugin/classloader/PluginClassLoader.java 0.00% 3 Missing ⚠️
...huaweicloud/sermant/core/common/LoggerFactory.java 0.00% 2 Missing ⚠️
...om/huaweicloud/sermant/core/AgentCoreEntrance.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1382      +/-   ##
=============================================
- Coverage      42.74%   42.61%   -0.13%     
+ Complexity      3312     3309       -3     
=============================================
  Files            829      830       +1     
  Lines          18437    18489      +52     
  Branches        2036     2036              
=============================================
- Hits            7881     7880       -1     
- Misses          9573     9624      +51     
- Partials         983      985       +2     
Flag Coverage Δ
unittests 42.61% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -87,6 +87,9 @@ public static void install(String artifact, Map<String, Object> argsMap, Instrum
artifactCache = artifact;
adviserCache = new DefaultAdviser();

// 初始化默认日志
Copy link
Collaborator

@provenceee provenceee Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

字体编码不对,乱码了

@kkf1 kkf1 changed the title 日志bug修复 logs bug fix. Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants