Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic config optimization #1585

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Jul 26, 2024

What type of PR is this?

Bug.

What this PR does / why we need it?

  1. The logic for determining the status code is added to the HTTP request.
  2. Remove the encryption of the user name.
  3. Optimize nacos token expiration time

Which issue(s) this PR fixes?

Fixes #1584

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Flag Coverage Δ Complexity Δ
unittests 42.99% <21.42%> (+0.08%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ Complexity Δ
...rvice/dynamicconfig/nacos/NacosBufferedClient.java 46.05% <33.33%> (-0.71%) 0.00 <0.00> (ø)
...or/service/report/PrometheusMetricServiceImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...dynamicconfig/nacos/NacosDynamicConfigService.java 61.07% <0.00%> (+0.36%) 0.00 <0.00> (ø)
...ement/service/dynamicconfig/nacos/NacosClient.java 63.52% <33.33%> (-3.95%) 0.00 <0.00> (ø)

... and 27 files with indirect coverage changes

lilai23
lilai23 previously approved these changes Jul 27, 2024
Signed-off-by: daizhenyu <1449308021@qq.com>
@Sherlockhan Sherlockhan merged commit 8eb1384 into sermant-io:develop Jul 27, 2024
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos dynamic configuration has some problems in the code logic
4 participants