Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graceful shutdown notify failure #1590

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

lilai23
Copy link
Collaborator

@lilai23 lilai23 commented Jul 31, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

When one instance of provider is going to be shutdown,send requests continuously to it. Sometimes we will get 500 response code. So this pr manages to make sure the notification to consumer is send correctly.

Which issue(s) this PR fixes?

Fixes #1589

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Files Patch % Lines
...ermant/registry/service/impl/GraceServiceImpl.java 44.44% 5 Missing ⚠️
...n/java/io/sermant/registry/config/GraceConfig.java 50.00% 2 Missing ⚠️
Flag Coverage Δ Complexity Δ
unittests 42.97% <50.00%> (-0.02%) 182.00 <1.00> (+1.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ Complexity Δ
...sermant/registry/entity/GraceShutdownBehavior.java 80.95% <100.00%> (+0.95%) 0.00 <0.00> (ø)
...n/java/io/sermant/registry/config/GraceConfig.java 57.89% <50.00%> (-0.35%) 29.00 <1.00> (+1.00) ⬇️
...ermant/registry/service/impl/GraceServiceImpl.java 66.66% <44.44%> (-8.34%) 0.00 <0.00> (ø)

... and 1 file with indirect coverage changes

@lilai23 lilai23 force-pushed the grace_shutdown_fix branch 2 times, most recently from 3af06e3 to 69f9f5c Compare August 1, 2024 06:28
Signed-off-by: lilai <lilai23@foxmail.com>
@Sherlockhan Sherlockhan merged commit db1ef48 into sermant-io:develop Aug 5, 2024
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In graceful shutdown plugin it may send request to wrong instance with a small probability
4 participants