Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service status check to optimize xds integration test #1594

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Aug 6, 2024

What type of PR is this?

Integration test.

What this PR does / why we need it?

Add service status check to optimize xds integration test

Which issue(s) this PR fixes?

Fixes #1592

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Signed-off-by: daizhenyu <1449308021@qq.com>
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ Complexity Δ
unittests 43.03% <ø> (+0.04%) 182.00 <ø> (+1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

@Sherlockhan Sherlockhan merged commit 53c85fa into sermant-io:develop Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xds integration test run fails sometimes
4 participants