Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds framework util #1608

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

daizhenyu
Copy link
Collaborator

@daizhenyu daizhenyu commented Aug 30, 2024

What type of PR is this?

Feature.

What this PR does / why we need it?

xds framework util class to parse xds data:

  1. CdsProtocolTransformer
  2. RdsProtocolTransformer
  3. LdsProtocolTransformer
  4. XdsCommonUtils

Which issue(s) this PR fixes?

Fixes #1604

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 85.62092% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ment/service/xds/utils/RdsProtocolTransformer.java 80.45% 11 Missing and 6 partials ⚠️
...ment/service/xds/utils/LdsProtocolTransformer.java 85.00% 3 Missing ⚠️
...ment/service/xds/utils/CdsProtocolTransformer.java 95.12% 1 Missing and 1 partial ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.26% <85.62%> (+0.47%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...nt/implement/service/xds/utils/XdsCommonUtils.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...ment/service/xds/utils/CdsProtocolTransformer.java 95.12% <95.12%> (ø) 0.00 <0.00> (?)
...ment/service/xds/utils/LdsProtocolTransformer.java 85.00% <85.00%> (ø) 0.00 <0.00> (?)
...ment/service/xds/utils/RdsProtocolTransformer.java 80.45% <80.45%> (ø) 0.00 <0.00> (?)

... and 18 files with indirect coverage changes

@daizhenyu daizhenyu force-pushed the develop-xds-route-930 branch 2 times, most recently from 49940a4 to 0d11927 Compare September 2, 2024 11:11
Signed-off-by: daizhenyu <1449308021@qq.com>
@Sherlockhan Sherlockhan merged commit a3abf86 into sermant-io:develop Sep 3, 2024
280 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support obtaining Istio routing and load balancing configurations based on the xDS protocol
4 participants