Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Backend Use Nacos cause OutOfMemoryError #1614

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

AYue-94
Copy link

@AYue-94 AYue-94 commented Sep 5, 2024

What type of PR is this?

Bug.

What this PR does / why we need it?

When configcenter use nacos, remove sermant reconnect logic, because nacos will reconnect by itself.

Which issue(s) this PR fixes?

Fixes #1613

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

Signed-off-by: ayue <ericyu0421@163.com>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ Complexity Δ
unittests 43.35% <100.00%> (+0.09%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...rvice/dynamicconfig/nacos/NacosBufferedClient.java 52.45% <100.00%> (+6.40%) 0.00 <0.00> (ø)
...java/io/sermant/backend/service/ConfigService.java 28.87% <ø> (+0.98%) 0.00 <0.00> (ø)

... and 28 files with indirect coverage changes

@lilai23
Copy link
Collaborator

lilai23 commented Sep 5, 2024

please use our pr template to describe this pr

@AYue-94
Copy link
Author

AYue-94 commented Sep 5, 2024

fixed

@Sherlockhan Sherlockhan merged commit acda541 into sermant-io:develop Sep 18, 2024
281 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend Use Nacos cause OutOfMemoryError
4 participants