Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graceful shutdown notify failure #1630

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

provenceee
Copy link
Collaborator

@provenceee provenceee commented Sep 23, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

When one instance of provider is going to be shutdown,send requests continuously to it. Sometimes we will get 500 response code. So this pr manages to make sure the notification to consumer is send correctly.

Which issue(s) this PR fixes?

Fixes #1589

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@provenceee provenceee changed the title *Fix graceful shutdown notify failure Fix graceful shutdown notify failure Sep 23, 2024
@provenceee provenceee self-assigned this Sep 23, 2024
@provenceee provenceee force-pushed the fix-grace branch 2 times, most recently from 18d4bc1 to 1263f4c Compare September 23, 2024 09:29
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ermant/registry/service/impl/GraceServiceImpl.java 81.57% 2 Missing and 5 partials ⚠️
Flag Coverage Δ Complexity Δ
unittests 43.84% <85.10%> (+0.05%) 181.00 <0.00> (-1.00) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
...n/java/io/sermant/registry/config/GraceConfig.java 58.24% <ø> (+0.34%) 28.00 <0.00> (-1.00) ⬆️
...try/config/RegistryConfigSubscribeServiceImpl.java 17.39% <ø> (+1.39%) 0.00 <0.00> (ø)
...n/java/io/sermant/registry/utils/RefreshUtils.java 87.17% <100.00%> (ø) 0.00 <0.00> (ø)
...o/sermant/registry/service/cache/AddressCache.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ermant/registry/service/impl/GraceServiceImpl.java 79.66% <81.57%> (+12.99%) 0.00 <0.00> (ø)

... and 2 files with indirect coverage changes

@provenceee provenceee force-pushed the fix-grace branch 6 times, most recently from ec166f0 to 7ddee74 Compare September 27, 2024 02:46
Signed-off-by: provenceee <83857838+provenceee@users.noreply.github.com>
@Sherlockhan Sherlockhan merged commit a5c184a into sermant-io:develop Sep 30, 2024
86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In graceful shutdown plugin it may send request to wrong instance with a small probability
4 participants