Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DMS-68] Use direct recursion in folding functions #12

Closed
wants to merge 2 commits into from
Closed

[DMS-68] Use direct recursion in folding functions #12

wants to merge 2 commits into from

Conversation

s-and-witch
Copy link
Collaborator

Comparison versus #10:

size foldLeft foldRight mapfilter map
persistentmap 100 18_597 18_509 157_384 29_048
persistentmap_baseline 100 79_472 79_588 157_392 29_048
persistentmap 1000 154_997 153_509 2_355_770 1_332_475
persistentmap_baseline 1000 761_667 762_619 3_430_215 257_766
persistentmap 10000 1_521_863 1_503_632 42_053_834 2_544_359
persistentmap_baseline 10000 7_582_712 18_270_414 42_053_473 2_544_359
persistentmap 100000 15_198_893 15_004_493 493_211_693 132_210_500
persistentmap_baseline 100000 182_610_151 182_615_427 493_211_373 132_210_500
persistentmap 1000000 151_997_225 150_013_513 5_637_834_835 1_322_035_748
persistentmap_baseline 1000000 1_826_050_546 1_826_067_207 5_637_839_066 1_322_035_748

@s-and-witch s-and-witch changed the title Use direct recursion in folding functions [DMS-68] Use direct recursion in folding functions Oct 9, 2024
This was referenced Oct 9, 2024
Closed
Closed
@GoPavel GoPavel mentioned this pull request Oct 10, 2024
Closed
@GoPavel
Copy link

GoPavel commented Oct 10, 2024

Probably we should choose this version of folds as the best one and then update related comparisons?

@s-and-witch
Copy link
Collaborator Author

Probably we should choose this version of folds as the best one and then update related comparisons?

Yes, I think so, unless you have something in mind.

@GoPavel
Copy link

GoPavel commented Oct 14, 2024

note: to merge

This was referenced Oct 14, 2024
Merged
Open
Open
@GoPavel GoPavel added experiment experiment experiment:to-merge Successful optimization that intented to moved to another PR labels Oct 21, 2024
@GoPavel GoPavel closed this Oct 21, 2024
@GoPavel GoPavel removed the experiment experiment label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experiment:to-merge Successful optimization that intented to moved to another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-and-witch @GoPavel