Replace Deprecated Account type with Keypair

[Imaclean74]

The Account class was recently deprecated in favor of Keypair in the upstream solana python package as well as the js web3 library. This PR brings pyserum in line with that and resolves #88 and #89

Summary of changes:

• Replace all usage of Account with Keypair
• update all relevant tests as well

solana-py change :
michaelhly/solana-py#62

web3 :
Deprecate Account for Keypair: https://solana-labs.github.io/solana-web3.js/classes/account.html

[vikulikov]

successfully placed an order with this PR

[Imaclean74]

thanks for verifying @vikulikov. I'm working to get the integration tests all working. Had some issues bootstrapping serum-dex locally.

[leofisG]

Hey @Imaclean74 , anything that I can help with?

[Imaclean74]

thanks @leonardgee. I've had some issues running the integration tests locally - older PC not running the release builds of solana. So have been pushing fixes and waiting for the CI to run :(
if the last commit still triggers errors - it would be great if you could run the integration tests locally - and flag any required fixes.

[Imaclean74]

oh - and there is also some weirdness with stubbed_base_mint() in conftest.py. It was returning an Account ( changed to Keypair ), but it should almost certainly be a public_key - which is what test_bootstrapped_market() has in it's type hints. But then it was doing a public_key() call on the input which would only work if passed an Account. if you have some insight into how the bootstrapping should work in conftest.py that would be great. Maybe just as simple as returning something like return PublicKey(__bs_params["coin_mint"]) from stubbed_base_mint() ?

[Imaclean74]

@leonardgee I have the integration tests passing locally now - against Solana v1.5.8. With the latest ( 1.7.15 ) I'm getting a couple of failures that will need digging in to. However that looks unrelated to my Account -> Keypair change. It might be tidier to address that in a separate PR ?

[codecov]

Codecov Report

Merging #92 (02afda8) into alpha (4ab65b0) will not change coverage.
The diff coverage is 76.19%.

@@           Coverage Diff           @@
##            alpha      #92   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files          24       24           
  Lines        1053     1053           
=======================================
  Hits          918      918           
  Misses        135      135           

[Imaclean74]

thanks for merging @michaelhly. Would this now be ready to publish to Pypi ?

[leofisG]

Thanks for this! @Imaclean74

[leofisG]

Why is the doc failure after merge. 🤔 Is this caused by the dependency upgrade?