Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File permissions are clobbered during the packaging step #25

Open
pdsarin opened this issue Feb 13, 2020 · 0 comments
Open

File permissions are clobbered during the packaging step #25

pdsarin opened this issue Feb 13, 2020 · 0 comments

Comments

@pdsarin
Copy link

pdsarin commented Feb 13, 2020

Hi!

When this component packages files for deployment, it doesn't preserve file permissions. That's an issue for the go lambda runtime as the lambda handler is an executable that needs execution permissions.

I wrote a patch here but I'm submitting this issue before putting in a pull request, per the contribution guidelines. I tested by running the unit tests and by verifying that execution permissions were preserved. Happy to send up a PR or to add additional tests, with a little guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant