Skip to content

Commit

Permalink
Merge pull request #63 from serverlessworkflow/fix-cataloged-function…
Browse files Browse the repository at this point in the history
…-validation-check

Fixed the `CallTaskDefinitionValidator` to not check the inline definition of cataloged functions (which contain an '@' character)
  • Loading branch information
cdavernas authored Oct 18, 2024
2 parents 007c6df + a3fe0b2 commit f962a7e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<VersionPrefix>1.0.0</VersionPrefix>
<VersionSuffix>alpha3</VersionSuffix>
<VersionSuffix>alpha3.1</VersionSuffix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<VersionPrefix>1.0.0</VersionPrefix>
<VersionSuffix>alpha3</VersionSuffix>
<VersionSuffix>alpha3.1</VersionSuffix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
2 changes: 1 addition & 1 deletion src/ServerlessWorkflow.Sdk/ServerlessWorkflow.Sdk.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<VersionPrefix>1.0.0</VersionPrefix>
<VersionSuffix>alpha3</VersionSuffix>
<VersionSuffix>alpha3.1</VersionSuffix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<FileVersion>$(VersionPrefix)</FileVersion>
<NeutralLanguage>en</NeutralLanguage>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public CallTaskDefinitionValidator(IServiceProvider serviceProvider, ComponentDe
this.Components = components;
this.RuleFor(c => c.Call)
.Must(ReferenceAnExistingFunction)
.When(c => !Uri.TryCreate(c.Call, UriKind.Absolute, out _))
.When(c => !Uri.TryCreate(c.Call, UriKind.Absolute, out _) || c.Call.Contains('@'))
.WithMessage(ValidationErrors.UndefinedFunction);
this.When(c => c.Call == Function.AsyncApi, () =>
{
Expand Down

0 comments on commit f962a7e

Please sign in to comment.