Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document context of task.if #1005

Conversation

matthias-pichler
Copy link
Collaborator

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

#1001

What this PR does:

I extended the description of the task.if property and included it in the data flow digram

Additional information:

dsl-reference.md Outdated Show resolved Hide resolved
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers man ❤️

Can I ask you to sign-off, though?

@cdavernas cdavernas changed the title Document context of task.if Document context of task.if Aug 30, 2024
@cdavernas cdavernas added change: fix Something isn't working. Impacts in a minor version change. change: documentation Improvements or additions to documentation. It won't impact a version change. labels Aug 30, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Aug 30, 2024
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
Signed-off-by: Matthias Pichler <m.pichler@warrify.com>
@cdavernas cdavernas merged commit 62ff5e8 into serverlessworkflow:main Aug 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change: documentation Improvements or additions to documentation. It won't impact a version change. change: fix Something isn't working. Impacts in a minor version change.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants