Make CFRunLoopMode a safe wrapper with a lifetime #650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #648: the safe methods that take
CFRunLoopMode
are currently unsound because it is a raw pointer that is not necessarily valid.As a bonus, this allows use of
kCFRunLoopCommonModes
andkCFRunLoopDefaultMode
constants withoutunsafe
.I considered just making
mode
a&CFString
, but it seems that the implementation compares the pointer values, so this way ensures that the constants are passed as the pointers it expects. I don't understand the purpose or usage ofmode
very well, so correct me if this is not ideal.