Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RSA_METHOD Bindings #2219

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

brimonk
Copy link

@brimonk brimonk commented Apr 11, 2024

Changes

While the previous engine pr (#2006) is more than enough for me and my own purposes, I had a really hard time getting it through CI, I had a hard time creating a PR from the ENGINE bindings first, and keeping the scope relatively small. Now, I'm going to try to go about it from the other direction :)

There's also the question of testing this thoroughly. I think the only way that this could be tested reasonably is if I create a fake testing only engine, and have it assert that it gets called at various points during the engine lifecycle. @sfackler to have some input on testing, now that I hopefully have a PR with a smaller scope.

This is probably not all of the bindings, but it's all of the ones from
the documentation:
    https://www.openssl.org/docs/man1.1.1/man3/RSA_meth_new.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant