Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/fetch stock prices on demand #11

Merged
merged 34 commits into from
Mar 11, 2024

Conversation

sgobotta
Copy link
Owner

@sgobotta sgobotta commented Mar 9, 2024


name: Pull Request
about: Economize finnhub requests
title: ''
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Add a cafecito button component
  • Remove unused imports
  • Update cedear msg translations
  • Install gen_stage
  • Install phoenix_inline_svg
  • Configure phoenix_inline_svg
  • Update logos
  • Add support to log errors on ExFinnhub.Client
  • Create a Channels module to broadcast stock price events
  • Add support to add entries to redis streams
  • Implement a stock price server to continuously fetch prices
  • Make Redis Application module functions available globally
  • Implement and configure modules to fetch and listen to stock price events
  • Update cedear liveview to receive stock prices updates
  • Add support to fetch stock price if exists on handle_params
  • Remove shadow change on hover
  • Minor style updates
  • Update mix version

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

…ents

* Implement a StockPrices context
* Update the StockPrice api module to support holding a stock price symbol
* Implement a stock price supervisor and a watcher that notifies stock price updates
* This update removes the elixir warning at runtime for the 'missing ex_finnhub app'
@sgobotta sgobotta merged commit 773361a into dev Mar 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant