Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/upgrade to daily graphs for dollar quotes #13

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

sgobotta
Copy link
Owner


name: Pull Request
about: Update currency charts
title: ''
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Implement a stream module to refactor some redis code
  • Fixup xrevrange params order
  • Group quote history by day
  • Update suggestedmin/max for the charts
  • Add a function to fetch stream entry datetime
  • Fix filter_history_entries to properly sort elements
  • Improvements in the Show view for dollar quotes
  • Add support to fetch history by week and month
  • Update translations
  • Update the line chart to calculate suggested min and max
  • Add an event handler to reset datasets
  • Add support to select intervals in currency quotes
  • Update version

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sgobotta sgobotta merged commit 1c03b91 into dev Mar 13, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant