Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add cedears calculator #6

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Conversation

sgobotta
Copy link
Owner

@sgobotta sgobotta commented Dec 1, 2023


name: Pull Request
about: Let us know about your contribution
title: ''
labels: ''
assignees: '@sgobotta'

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR provides:

  • Add an instruments context for a cedear model and producer
  • Add search bar client modules
  • Add a cedears calculator
  • Add translations
  • Bump to version 0.1.1

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

Provide instructions so we can reproduce the cases. Please also list any relevant details for your test configuration.

Instructions:

  1. Visit /cedears
  2. Search for a cedear
  3. Input a cedear value

Expected result: check the calculated average price

Checklist

The following options in bold are required for a PR approval. Please check the boxes only if necessary, it help us minimizing the reviewing process.

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sgobotta sgobotta merged commit cbffc76 into dev Dec 1, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant