Skip to content

Commit

Permalink
Do Not Specify Default Serial (#261)
Browse files Browse the repository at this point in the history
We wrapped this launch file into our own launch structure and
initially failed to add the new hand_serial parameter during migration to noetic.
So although we specified the correct serial in other places it loaded
the wrong calibration without complains and the hand misbehaves.

Crucial configuration parameters must really not have defaults.
  • Loading branch information
v4hn authored Jun 30, 2022
1 parent 7149ea5 commit 5483db7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sr_robot_lib/launch/sr_hand_lib.launch
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
If it's not "" then it's usually "rh" -->
<arg name="hand_id" default="rh"/>
<!-- The ethercat serial number for the hand -->
<arg name="hand_serial" default="111"/>
<arg name="hand_serial" />
<!-- the path to the mapping files -->
<arg name="mapping_path" default="$(find sr_edc_launch)/mappings/default_mappings/rh_E_v3.yaml"/>

Expand Down

0 comments on commit 5483db7

Please sign in to comment.