fix upload authentication vulnerability #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(1) calling this a vulnerability is an error since the documentation is currently clear that it's designed to provide a single password that functions as a shared secret - "authentication improvement" would be a better description IMO (and I'm fine with the ensuing compat breakage provided we detect the old-style auth tokens and barf) General shape of the PR seems fine at a first look though, the above is all arguably details |
…pload argument name in docs
only checked password, not username This required to change the OPAN_AUTH_TOKENS, see the docs for detailsFix upload authentication vulnerability only checked password, not username This required to change the OPAN_AUTH_TOKENS, see the docs for detailsfix upload authentication vulnerability only checked password, not username This required to change the OPAN_AUTH_TOKENS, see the docs for details
abraxxa
force-pushed
the
master
branch
2 times, most recently
from
db48e41
to
26992f9
Compare
this broke App::cpm 0.997003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.