Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromedriver Download URL Change #35

Open
TillerBurr opened this issue Aug 18, 2023 · 6 comments
Open

Chromedriver Download URL Change #35

TillerBurr opened this issue Aug 18, 2023 · 6 comments

Comments

@TillerBurr
Copy link

Starting with version 115, the chromedriver is downloaded in a different location in the json endpoints. This project will install the chromedriver up to version 114 due to these new endpoints.
@TillerBurr
Copy link
Author

There are a couple of things that need to be decided how to approach this. There is no /LATEST_RELEASE page that I can find. It appears to me that it will involve hitting one of the end points and then parsing the response to find the latest release. To be able to move forward with changes, there are a few questions that should be decided.

  • What is considered the latest release? Is it stable, beta, dev or canary? Once that is decided, it's fairly straight forward to get the last known good version.
  • Should the new logic be in it's own module? The current tests for Chrome assume that the /LATEST_RELEASE endpoint exists and is accurate. If the new logic is put into the same chrome.py, the testing will have to be overhauled. If it's in it's own module, it should be enough to create new tests.

ntsim added a commit to dfe-analytical-services/explore-education-statistics that referenced this issue Aug 19, 2023
@ntsim
EES-4444 Use webdriver-manager for Chromedriver downloads
d59c8df 
This replaces Pyderman, which currently doesn't support Chrome 115+
due to recent changes in how Chrome versions are published.

See:
- SergeyPirogov/webdriver_manager#580
- shadowmoose/pyderman#35
@ntsim ntsim mentioned this issue Aug 21, 2023
Merged
ntsim added a commit to dfe-analytical-services/explore-education-statistics that referenced this issue Aug 21, 2023
@ntsim
EES-4444 Use webdriver-manager for Chromedriver downloads
5fed3ff 
This replaces Pyderman, which currently doesn't support Chrome 115+
due to recent changes in how Chrome versions are published.

See:
- SergeyPirogov/webdriver_manager#580
- shadowmoose/pyderman#35
@MarcelWilson
Copy link

the testing will have to be overhauled.

After a while is it going to make sense to keep the old logic which allows users to pull down older webdrivers?

@MarcelWilson
Copy link

Do we know if the changes to chromedriver will apply to the chromium variants? i.e. Edge?

@TillerBurr
Copy link
Author

Do we know if the changes to chromedriver will apply to the chromium variants? i.e. Edge?

As of right now, I would think it will remain the same. The latest stable is 115 using the links in drivers.edge, but the XML tree contains up to version 118.

@MarcelWilson
Copy link

I haven't looked at this yet, but figured I would try to tackle it this week. But before I do, I have to ask if anyone has tried the selenium webdriver manager? Does it effectively kill the need for pyderman?

@mmyoungman
Copy link

We've switched from pyderman to webdriver-manager. If someone is looking to do the same, here are the changes we needed to make: https://github.com/dfe-analytical-services/explore-education-statistics/pull/4254/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmyoungman @TillerBurr @MarcelWilson