Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eip-6963 support #689

Merged
merged 49 commits into from
Oct 21, 2024
Merged

feat: eip-6963 support #689

merged 49 commits into from
Oct 21, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Oct 3, 2024

a.k.a "The Big Short (2015)".

⚠️ Ready for conceptual review and early testing with its web companion, but not ready to merge until web is ready - few things to tackle there both from a technical and product perspective.
Most likely, nothing will change here in hdwallet-land as the changeset is extremely low and we shouldn't require anything more, though some smolish follow-ups could be made:

  • Phantom leverages EIP provider
  • Keplr EVM support is added through EIP provider

This PR brings EIP-6963 support through passing an rdns when instantiating metamask, and detecting the correct provider instead of detectEthereumProvider. That's it.
All the other changes here are effectively:

  • removal of unused hdwallet-metamask (flag was off in web for a long time already and we weren't hitting its branch)
  • removal of now unused hdwallet-xdefi
  • removal of now unused hdwallet-coinbase
  • removal of unused hdwallet-tallyho

See inline comments for the only actual change in this mist of red lines.

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 3:51pm

@gomesalexandre gomesalexandre changed the title [skip ci]: wip: the big short feat: eip-6963 support Oct 3, 2024
@gomesalexandre gomesalexandre merged commit c197ede into master Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants