Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to fetch rates for all swapper protocols when trading between acounts #4966

Closed
purelycrickets opened this issue Jul 21, 2023 · 3 comments · Fixed by #5834
Closed

Unable to fetch rates for all swapper protocols when trading between acounts #4966

purelycrickets opened this issue Jul 21, 2023 · 3 comments · Fixed by #5834
Assignees
Labels
bug Something isn't working needs engineering Requires engineering input before bounty needs product Requires product input before bounty V3 Swapper

Comments

@purelycrickets
Copy link

Overview

When using swapper and trading between Account 0 and 1, a user in unable to fetch rates.

References and additional details

When the Thornode went down this was much more apparent as the only rates being fetched for swaps between different accounts currently are thor and osmo rates.

Screenshot 2023-07-21 at 12 30 56 PM

Acceptance Criteria

Trading between different accounts in swapper (account 0 > account 1) provides accurate rates for all available swapper protocols.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@purelycrickets purelycrickets added needs engineering Requires engineering input before bounty needs product Requires product input before bounty labels Jul 21, 2023
@gomesalexandre gomesalexandre self-assigned this Jul 21, 2023
@0xean 0xean assigned 0xean and unassigned gomesalexandre Dec 6, 2023
@0xean 0xean added V3 Swapper bug Something isn't working labels Dec 7, 2023
@0xean 0xean removed their assignment Dec 7, 2023
@0xean
Copy link
Contributor

0xean commented Dec 11, 2023

This may be related to certain swappers not support a different final address for the swap, but this is not apparent to the user and we should give them better messaging about the issue.

@0xApotheosis
Copy link
Contributor

0xApotheosis commented Dec 12, 2023

This is not a bug, but rather a lack of functionality.

  • Some swappers, such as 0x, do not support cross-account swaps.
  • THORChain does, and this is currently the only swapper that does support it, and is wired up to use it.
  • 1inch allows it via their API, so I've made a PR that enables cross-chain swaps for our 1inch swapper, too: feat: add cross-account trading for 1inch #5834 (which will close this ticket).

I'll also investigate doing the same for LiFi, though @woodenfurniture might have some info on why this isn't already turned on there.

@0xApotheosis
Copy link
Contributor

0xApotheosis commented Dec 12, 2023

Also got LiFi working for cross-account trades in #5835.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs engineering Requires engineering input before bounty needs product Requires product input before bounty V3 Swapper
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants