Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet Connect (Connecting a wallet to app.shapeshif.com) is broken #4984

Closed
tshifty opened this issue Jul 26, 2023 · 3 comments
Closed

Wallet Connect (Connecting a wallet to app.shapeshif.com) is broken #4984

tshifty opened this issue Jul 26, 2023 · 3 comments
Labels
needs engineering Requires engineering input before bounty
Milestone

Comments

@tshifty
Copy link

tshifty commented Jul 26, 2023

Overview

Right now if a user tries to scan the QR code to connect their wallet, either nothing happens or an error pops up on the app they are using.

Recreation Steps:

  1. Use any wallet that supports wallet connect and try to link your wallet to app.shapeshift.com
  2. Notice nothing happens when you attempt the connections and some apps just display and error.

References and additional details

N/A

Acceptance Criteria

Users should be able to connect their wallet through wallet connect to app.shapeshift.com

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@tshifty tshifty added the needs engineering Requires engineering input before bounty label Jul 26, 2023
@tshifty
Copy link
Author

tshifty commented Jul 26, 2023

I understand that this was reported a while ago. Just didn't see a ticket for the issue. If you already have one open please link it here and close the ticket

@gomesalexandre
Copy link
Contributor

@tshifty I think we can close #4976 in favor of this, which is more accurate, since we don't crash anymore but still have issues broadcasting messages

@purelycrickets
Copy link

closing in deference to the new implementation in #5228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty
Projects
None yet
Development

No branches or pull requests

3 participants