Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Modal doesn't update once TX is broadcast #5001

Closed
2 tasks done
MBMaria opened this issue Jul 31, 2023 · 1 comment · Fixed by #5004
Closed
2 tasks done

Send Modal doesn't update once TX is broadcast #5001

MBMaria opened this issue Jul 31, 2023 · 1 comment · Fixed by #5004
Assignees
Labels
needs engineering Requires engineering input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Jul 31, 2023

Overview

When completing a send, it will broadcast the transaction then remain on the Confirm screen. It allows you to select Confirm again and it will complete another send. Easy to think the first one failed and select Confirm again. However the green toast appears and the transaction does complete... twice... if you hit confirm twice :P

References and additional details

  1. Log into app.shapeshift and connect to wallet of choice
  2. Select an asset to send and enter details for a send
  3. Confirm send and note that is says "Send broadcasting". After a second it reverts to "Confirm" and then shortly after the green toast will appear in the top right hand corner.
    image

Acceptance Criteria

Send modal should move across to complete after the transaction has sent

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added the needs engineering Requires engineering input before bounty label Jul 31, 2023
@gomesalexandre
Copy link
Contributor

Introduced by #4972 and/or #4971, diffing send modal things there might help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs engineering Requires engineering input before bounty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants