Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapper balance check is broken #5011

Closed
2 tasks done
MBMaria opened this issue Aug 2, 2023 · 1 comment
Closed
2 tasks done

Swapper balance check is broken #5011

MBMaria opened this issue Aug 2, 2023 · 1 comment
Assignees

Comments

@MBMaria
Copy link

MBMaria commented Aug 2, 2023

Overview

When trading, you can enter an amount more than is available in your wallet and will allow you to preview trade

References and additional details

  1. Log into app.shapshift and connect to wallet of choice
  2. Navigate to the trade page
  3. Enter a trade where the input asset is more than the balance in your wallet
  4. Note you can select preview trade
    image

Acceptance Criteria

Should not be able to preview a trade when the balance entered is higher than the amount in the walllet

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@0xApotheosis
Copy link
Contributor

Closed by #5043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants