Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useGetABI doesn't support ERC-1967-compliant proxy contracts #5054

Closed
0xMillz opened this issue Aug 8, 2023 · 1 comment · Fixed by #5368
Closed

useGetABI doesn't support ERC-1967-compliant proxy contracts #5054

0xMillz opened this issue Aug 8, 2023 · 1 comment · Fixed by #5368

Comments

@0xMillz
Copy link
Contributor

0xMillz commented Aug 8, 2023

Problem:
Using WalletConnect with most proxy contracts fails with no matching function error
image

Suggested fix:
Add the 'implementation' method to this Set and handle it (it doesn't taking any args unlike getFunctionImplementation).

const proxyFunctions = new Set(['getFunctionImplementation'])

Why it matters:
ERC-1967 with the implementation() method is the most commonly used way to get the ABI of the logic contract from a proxy contract.

@0xMillz
Copy link
Contributor Author

0xMillz commented Aug 8, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant