Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price impact wrong way round - positive price movement #5066

Closed
2 tasks done
MBMaria opened this issue Aug 11, 2023 · 0 comments · Fixed by #5087
Closed
2 tasks done

Price impact wrong way round - positive price movement #5066

MBMaria opened this issue Aug 11, 2023 · 0 comments · Fixed by #5087
Assignees

Comments

@MBMaria
Copy link

MBMaria commented Aug 11, 2023

Overview

Currently the price impact feature is done in the wrong direction, as in its a positive price movement

References and additional details

  1. Log into app.shapeshift and connect to wallet of choice
  2. Navigate to trade page and enter a trade which will have a price impact (eg i used USDT to USDC with cowswap)
  3. Note the price impact.
    image

Acceptance Criteria

Price impact should accurate represent the percent loss of the trade

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants