Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse THORChain streaming swaps #5092

Closed
0xApotheosis opened this issue Aug 17, 2023 · 3 comments · Fixed by #5209
Closed

Parse THORChain streaming swaps #5092

0xApotheosis opened this issue Aug 17, 2023 · 3 comments · Fixed by #5209
Assignees

Comments

@0xApotheosis
Copy link
Contributor

0xApotheosis commented Aug 17, 2023

Overview

Relates to #5090

A THORChain streaming swap needs to be parsed correctly to show as a row in the TX history.

References and additional details

An example is https://thorchain.net/tx/3724248A21076A9DB6680F1C5271F45ABD6E87B08C6108265E588DDD486C56E5, which (to confirm, but I think) creates multiple on-chain transactions (see https://thorchain.net/address/0x4631d0da805c01705c7d7d7d922a01ae8a6fb13c).

We need to ensure this shows as one atomic trade row (use the thorchain.net UI for inspiration).

We might need to use the memo to link TXs, to confirm. If so, this URL may be useful: https://docs.thorswap.finance/thorswap/thorswap/streaming-swaps

Acceptance Criteria

We parse a streamed THORSwap and show it as one row in TX history.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@0xApotheosis 0xApotheosis self-assigned this Aug 17, 2023
@0xApotheosis
Copy link
Contributor Author

0xApotheosis commented Aug 23, 2023

As far as we can tell, there is actually only one inbound receive TX - so the scope of this ticket is really just to parse the memo and tag it as streaming if it is such.

@0xApotheosis
Copy link
Contributor Author

Re-opening, as the current implementation only seems to work on some trades (DOGE => RUNE, for e.g).

EVM swaps might use a different parser, and not actually add a memo?

@0xApotheosis 0xApotheosis reopened this Sep 5, 2023
@0xean 0xean assigned 0xean and unassigned 0xApotheosis and 0xean Dec 6, 2023
@kaladinlight kaladinlight self-assigned this Feb 6, 2024
@kaladinlight
Copy link
Contributor

This work has been completed with the recent thorchain tx parsing PRs (utxo, evm and cosmossdk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants