Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de-shapeshift osmo swapper #5097

Closed
0xdef1cafe opened this issue Aug 17, 2023 · 1 comment
Closed

de-shapeshift osmo swapper #5097

0xdef1cafe opened this issue Aug 17, 2023 · 1 comment
Assignees
@gomesalexandre
Milestone
SwapShillin

Comments

@0xdef1cafe
Copy link
Collaborator

Overview

  • remove getState from osmo swapper
  • remove accountIds from checkTradeStatus - use the TradeExecution class to emit events

References and additional details

.

Acceptance Criteria

.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@0xdef1cafe 0xdef1cafe added this to the SwapShillin milestone Aug 17, 2023
This was referenced Aug 19, 2023
Closed
Closed
@gomesalexandre gomesalexandre linked a pull request Aug 21, 2023 that will close this issue
feat: deserialized AccountIds input in Osmosis checkTradeStatus #5120
Closed
3 tasks
@gomesalexandre
Copy link
Contributor

Closing as the Osmosis/swapper is gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomesalexandre gomesalexandre

Labels
None yet
Projects
ShapeShift Dashboard
Archived in project
Milestone
SwapShillin
Development

Successfully merging a pull request may close this issue.

feat: deserialized AccountIds input in Osmosis checkTradeStatus shapeshift/web
2 participants
@gomesalexandre @0xdef1cafe