Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to thorchain swapper route creation #5110

Closed
woodenfurniture opened this issue Aug 20, 2023 · 0 comments · Fixed by #5115
Closed

Add error handling to thorchain swapper route creation #5110

woodenfurniture opened this issue Aug 20, 2023 · 0 comments · Fixed by #5115
Assignees

Comments

@woodenfurniture
Copy link
Member

woodenfurniture commented Aug 20, 2023

Overview

We constuct a memo and pass it to getEvmThorTxInfo and getUtxoThorTxInfo in order to then get fee data for the quote. The trouble is that the memo varies by route, meaning we need to re-fetch fee data by route. This pattern currently is done in a Promise.all(...) without error handling, which means if 1 route fails to generate, the quote quote fails. We want the swapper to only return an error monad if all routes failed, or return the successful ones otherwise.

References and additional details

src/lib/swapper/swappers/ThorchainSwapper/utxo/utils/getThorTxData.ts
src/lib/swapper/swappers/ThorchainSwapper/evm/utils/getThorTxData.ts

Acceptance Criteria

No reference to memos in getTradeQuote - this is an execution concern.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@woodenfurniture woodenfurniture self-assigned this Aug 20, 2023
@woodenfurniture woodenfurniture changed the title Remove memo from thorchain quotes Add error handling to thorchain swapper route creation Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant