Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lifiToolsMap from lifi swapper #5111

Closed
woodenfurniture opened this issue Aug 20, 2023 · 0 comments · Fixed by #5113
Closed

Remove lifiToolsMap from lifi swapper #5111

woodenfurniture opened this issue Aug 20, 2023 · 0 comments · Fixed by #5113
Assignees
@woodenfurniture

Comments

@woodenfurniture
Copy link
Member

woodenfurniture commented Aug 20, 2023 •
edited
Loading

Overview

The tool info lookup used for lifi quotes is not required because the information exists on the lifi quote. Remove it

References and additional details

src/lib/swapper/swappers/LifiSwapper/getTradeQuote/getTradeQuote.ts
See toolInfo.

Additional context #5095 (comment)

Acceptance Criteria

lifiToolsMap and associated initialisation code is removed.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
None yet
Projects
ShapeShift Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove redundant lifi tools map shapeshift/web
1 participant
@woodenfurniture