You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We need to upgrade the interfaces, logic and UI to support this in order to accurately represent trades on thorchain (and lifi).
Upgrade the interfaces in lib/swapper/api.ts:
export type Fee = { requiresBalance: boolean } & AmountDisplayMeta
export type QuoteFeeData<T extends ChainId> = {
networkFees: PartialRecord<AssetId, Fee> // fee(s) paid to the network from the fee asset (undefined if unknown)
protocolFees: PartialRecord<AssetId, Fee> // fee(s) paid to the protocol(s)
} & ChainSpecificQuoteFeeData<T>
And then upgrade the UI to display multiple network fees, simiilar to how we do for protocol fees.
Dont forget to include this additional network fee in calculations that take fees into account!
Dont forget to upgrade thorchain swapper with the outbound fee as per the link above!
The text was updated successfully, but these errors were encountered:
Currently our swappers and ui can only convey the concept of an "inbound network fee", however it's possible to have an "outbound network fee"
https://dev.thorchain.org/thorchain-dev/concepts/fees
We need to upgrade the interfaces, logic and UI to support this in order to accurately represent trades on thorchain (and lifi).
Upgrade the interfaces in
lib/swapper/api.ts
:And then upgrade the UI to display multiple network fees, simiilar to how we do for protocol fees.
Dont forget to include this additional network fee in calculations that take fees into account!
Dont forget to upgrade thorchain swapper with the outbound fee as per the link above!
The text was updated successfully, but these errors were encountered: