Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: general rendering performance improvements #4972

Merged
merged 8 commits into from
Jul 25, 2023
Merged

perf: general rendering performance improvements #4972

merged 8 commits into from
Jul 25, 2023

Conversation

woodenfurniture
Copy link
Member

@woodenfurniture woodenfurniture commented Jul 25, 2023 •
edited
Loading

Description

Adds some performance improvement to rendering around the app

  • changes to navbar rendering and how it reacts to changes to Location
  • pulling out hardcoded objects and arrays
  • memoizing everything else
  • reduction in dashboard chart granularity to 100 datapoints

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

NA

Risk

Moderate risk of broken:

  • navigation around the app
  • dashboard chart
  • general look of the UI
  • general behaviour of the UI

Testing

See above for areas to focus on.

Engineering

see above

Operations

see above

Screenshots (if applicable)

This was referenced Jul 25, 2023
Merged
Merged
@woodenfurniture
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@woodenfurniture woodenfurniture marked this pull request as ready for review July 25, 2023 03:27
@woodenfurniture woodenfurniture requested a review from a team as a code owner July 25, 2023 03:27
@woodenfurniture woodenfurniture changed the title perf: optimise balance chart perf perf: general rendering performance improvements Jul 25, 2023
@gomesalexandre gomesalexandre self-requested a review July 25, 2023 09:52
gomesalexandre
gomesalexandre approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a full regression test locally (minus broadcasting sends/trades) and I wasn't able to find any.
Stellar work ser, ran the app both as a dev server and an actual build and it's a lot snappier now! 🐐

Base automatically changed from modal-rerendering to develop July 25, 2023 11:01
@woodenfurniture woodenfurniture enabled auto-merge (squash) July 25, 2023 11:07
@woodenfurniture woodenfurniture merged commit 727b8ce into develop Jul 25, 2023
6 checks passed
@woodenfurniture woodenfurniture deleted the rendering-fixes branch July 25, 2023 11:23
@0xApotheosis 0xApotheosis mentioned this pull request Jul 26, 2023
Merged
0xdef1cafe pushed a commit that referenced this pull request Jul 31, 2023
@woodenfurniture @0xdef1cafe
perf: general rendering performance improvements (#4972)
4f37005
@gomesalexandre gomesalexandre mentioned this pull request Jul 31, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gomesalexandre gomesalexandre gomesalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woodenfurniture @gomesalexandre