Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add method & url to swapper mixpanel events #4977

Merged

Conversation

0xApotheosis
Copy link
Contributor

@0xApotheosis 0xApotheosis commented Jul 25, 2023

Description

Add url and method properties to swapper mixpanel events.

Pull Request Type

  • ๐Ÿ› Bug fix (Non-breaking Change: Fixes an issue)
  • ๐Ÿ› ๏ธ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • ๐Ÿ’… New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Adds to #4941.

Risk

Very small.

Testing

Mixpanel should now show the new properties in the "Your properties" event tab on the mixpanel Dashboard.

Engineering

โ˜๏ธ

Operations

โ˜๏ธ

Screenshots (if applicable)

Screenshot 2023-07-26 at 8 08 08 am

@0xApotheosis 0xApotheosis requested a review from a team as a code owner July 25, 2023 22:07
@0xApotheosis
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@0xdef1cafe 0xdef1cafe merged commit 54bba0f into develop Jul 25, 2023
3 checks passed
@0xdef1cafe 0xdef1cafe deleted the 07-26-chore_add_method_url_to_swapper_mixpanel_events branch July 25, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants