fix: borked walletconnect v2 send transaction confirmation #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
gomesalexandre
commented
Jul 25, 2023
gomesalexandre
commented
Jul 25, 2023
src/plugins/walletConnectToDapps/v2/components/modals/EIP155TransactionConfirmation.tsx
Show resolved
Hide resolved
gomesalexandre
commented
Jul 25, 2023
src/plugins/walletConnectToDapps/v2/components/modals/EIP155TransactionConfirmation.tsx
Show resolved
Hide resolved
gomesalexandre
commented
Jul 25, 2023
| nonce: transaction?.nonce ? convertHexToNumber(transaction.nonce).toString() : undefined, | ||
| gasLimit: | ||
| transaction?.gasLimit ?? transaction?.gas | ||
| ? convertHexToNumber((transaction?.gasLimit ?? transaction?.gas)!).toString() |
There was a problem hiding this comment.
Are we guaranteed to have either a gas or a gasLimit?
If not we might want to fallback to 0 or something so we don't throw.
0xApotheosis
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes WalletConnect transaction confirmation modal happy again, though the actual broadcasting still seems to be broken, with no error nor failed (or successful) XHR
tl;dr is we were too strict/not accurate on what makes a transaction a transaction, and throwing at
isTransactionParamstime.Pull Request Type
Issue (if applicable)
tackles #4976
Risk
Transaction detection and gas params may be broken, though WalletConnect to dApps seems to be entirely broken at the moment so can't make it more broken?
Testing
Engineering
closesOperations
Screenshots (if applicable)
App crashes