fix: hide donation for unsupported keepkey swaps #4996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
0xApotheosis
force-pushed
the
07-28-fix_hide_donation_for_unsupported_keepkey_swaps
branch
from
cc39948
to
85c2283
Compare
0xdef1cafe
approved these changes
Jul 31, 2023
0xdef1cafe
deleted the
07-28-fix_hide_donation_for_unsupported_keepkey_swaps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, KK signing EVM transactions with donations does not work (see #4518).
We should not show the donation button for these swaps, as it currently does nothing.
Pull Request Type
Issue (if applicable)
Closes #4993
Risk
Small
Testing
When connected to a KK, try a trade from an EVM asset with sufficient sell amount to allow for a donatiion.
The donation toggle should not show.
Trades from non-EVM assets should still allow donations with KK.
No other wallets should be affected by this PR.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
N/A