Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v1.399.0 #5056

Merged
merged 3 commits into from
Aug 9, 2023
Merged

chore: release v1.399.0 #5056

merged 3 commits into from
Aug 9, 2023

Conversation

0xApotheosis
Copy link
Contributor

feat: handle moderate price impact at input/confirm step (#5033)
feat: warn against high price impact at confirm step (#5032)

gomesalexandre and others added 3 commits August 9, 2023 14:40
* feat: handle high price impact/slippage at confirm step

* feat: cleanup

* fix: revert slippage bits and keep only price impact logic

* feat: tackle self-review comment

* feat: derp add missing % in copy

* fix: interpolation

* fix: derp

* chore: remove unused selector

* chore: use buy amount before fees

---------

Co-authored-by: Apotheosis <0xapotheosis@gmail.com>
Co-authored-by: Tim Black <timothy.william.black@gmail.com>
Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>
* feat: handle high price impact/slippage at confirm step

* feat: cleanup

* feat: handle moderate price impact at input/confirm step

* feat: add translation

* fix: revert slippage bits and keep only price impact logic

* fix price impact

* feat: rm slippage things again, again

* feat: self-review comments

* feat: tackle self-review comment

* feat: more cleanup

* feat: tackle self-review comment

* feat: derp add missing % in copy

* fix: interpolation

* fix: derp

* Update PriceImpact.tsx

* Update PriceImpact.tsx

* chore: remove unused selector

* chore: remove unused selector

* chore: use buy amount before fees

* perf: extract prop objects

* fix: use before fees value

---------

Co-authored-by: reallybeard <89934888+reallybeard@users.noreply.github.com>
Co-authored-by: Apotheosis <0xapotheosis@gmail.com>
Co-authored-by: Tim Black <timothy.william.black@gmail.com>
Co-authored-by: Apotheosis <97164662+0xApotheosis@users.noreply.github.com>
@0xApotheosis 0xApotheosis merged commit 326a9f9 into main Aug 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants