fix: trade ratio & CoW quote display

[0xApotheosis]

Description

• Fixes the trade ratio calculation, which was incorrectly handling sell asset fees (which currently only affects CoW Swap quotes)
• Fixes the display of sell asset fees, which were not correctly shown to the user (again, currently only affects CoW Swap quotes)
• Renames sellAmountBeforeFeesCryptoBaseUnit to sellAmountIncludingProtocolFeesCryptoBaseUnit, because that's what it actually is, and probably caused this bug

This PR is also important as it fixes the ratio data send to MixPanel.

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

Medium - quotes and their ratio/percent better/worse than display might be broken.

Testing

Get a quote for an asset pair with many supported swappers (e.g. USDC to FOX).

• Ensure that the percent difference looks sane
• Ensure that for CoW Swap quotes, we are subtracting the fee from the receive amount

Engineering

Inspect CoW quote network requests and ensure that the data matches what we are showing, particularly with regard to fees and receive amount.

Operations

Check our CoW quotes against https://swap.cow.fi/#/1/swap and ensure they are close.

Screenshots (if applicable)

[0xApotheosis]

Current dependencies on/for this PR:

• develop
  • PR fix: trade ratio & CoW quote display #5062 👈

This comment was auto-generated by Graphite.