fix: handle positive price impact #5087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
gomesalexandre
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Wasn't able to get price impact to show up on this pair on prod (neither positive nor negative), nor test on THOR which is currently down and the usual offender of high price impacts, but both commits (logic abstraction and positive price impact handling) LGTM, let's get this in
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull Request Type
Issue (if applicable)
Closes #5066
Risk
Small
Testing
Get a quote with a positive price impact (at the moment $20 FOX to ETH will do this).
Ensure the price impact warning does not show on either the quote screen or confirm screen.
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
Current prod (sad) state: