chore: remove manual memo calcs

[0xApotheosis]

Description

Use the memo value given to us by thorchain/swap/quote - there is no need to calculate it ourselves so long as we are providing the correct input data when fetching the quote.

Things still to check:

• Slippage input amount when hitting the GET request
• Refund handling for small swaps - we might need client-side logic to handle what was previously a swapper concern

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Assists with the Swapper SDK work by simplifying the input data needed to fetch a quote.

Risk

High - a bug with a THORSwap memo can lead to a total loss of trade funds. Test accordingly.

Testing

Check:

• We still get THORSwap quotes as expected

Engineering

Check:

• The memo returned from the thorchain/swap/quote endpoint matches what we expect (compare with that on prod if necessary with some inline debugging)

Operations

Check:

• THORSwap trades complete as expected, which a memo that matches expectations

Screenshots (if applicable)

N/A

[0xApotheosis]

Current dependencies on/for this PR:

• develop
  • PR chore: remove manual memo calcs #5094 👈
    • PR feat: upgrade swappers to support returning multiple quotes #5095
      • PR feat: thor streaming swaps quote #5106

This comment was auto-generated by Graphite.

[woodenfurniture]

amazing, you legend

[0xApotheosis]

This one could do with some good ol' fashioned @gomesalexandre scrutiny.

[gomesalexandre]

First pass, looking very good to me according to the updated test cases - functional pass to follow before making this purple

[gomesalexandre]

Tested against prod with RUNE <-> ATOM and RUNE -> DOGE:

RUNE <-> ATOM

• "You Get" amount is showing no regressions against prod

• Memo is looking good against prod

And limit is slightly higher too 🎉

• Trade is going through

RUNE -> DOGE

• "You Get" amount is showing no regressions against prod

Note how we get slightly more here 🎉

• Memo is looking good against prod

• Trade is going through

Notice how the receive amount is now higher, as a result of the higher limit 🎉