chore: add error handling to thorchain swapper route generation #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
woodenfurniture
force-pushed
the
thorchain-route-error-handling
branch
from
553ff88
to
50bb98e
Compare
woodenfurniture
changed the title
0xApotheosis
approved these changes
Aug 21, 2023
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds error handling to thorchain swapper route generation such that one failed route wont prevent successful routes from being displayed.
Pull Request Type
Issue (if applicable)
closes #5110
Risk
Low risk of broken quotes for thorchain swapper.
Testing
Test thor quotes are correctly generated.
Engineering
Recommended to review with whitespace off 🍻
Operations
☝️
Screenshots (if applicable)