feat: upgrade walletconnect ui to align to multiple connection design #5237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
woodenfurniture
changed the title
woodenfurniture
force-pushed
the
walletconnect-v2-ui
branch
from
d3a44d2
to
3cb5290
Compare
0xApotheosis
force-pushed
the
develop
branch
2 times, most recently
from
97f99eb
to
54924d2
Compare
...providers/thorchain-savers/components/ThorchainSaversManager/Withdraw/components/Confirm.tsx
Outdated
Show resolved
Hide resolved
woodenfurniture
force-pushed
the
walletconnect-v2-ui
branch
from
3cb5290
to
9a2e0a3
Compare
0xApotheosis
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the ui of the walletconnect dropdown to align to the multi-connection design. Does not implement multi-connections though - that will be in a follow-up.
Note that multiple address links appear as duplicates in the UI but point to different pages - this aligns to the design:
Pull Request Type
Issue (if applicable)
progresses #5236
Risk
Testing
Engineering
☝️
Operations
☝️
Screenshots (if applicable)
Default state (before connecting walletconnect) - unchanged from prod
App connected - unchanged from prod
Dropdown opened, default state - aligned to new design
Dropdown opened, collapsed state - aligned to new design. This isn't useful until multi-connection ui is implemented, but placeholder functionality is there.
