feat: add cross-account trading for 1inch

[0xApotheosis]

Description

Enables cross-account trading for 1inch.

Cross-account 1inch transactions created from this branch:

1. Fee asset account 0 to ERC20 account 1: https://snowtrace.dev/tx/0x93dea99cfa2663635a6314e0340fd890404ed3d999c04862520e83dbbacdf95f
2. Approval from non-0 ERC20 account: https://snowtrace.dev/tx/0xff2c18378bd4fff274d471841a7d28d5d188d86c84866f420aa4677e52ec213b
3. ERC20 account 1 to fee asset account 0: https://snowtrace.dev/tx/0xa9b8cca119c09f3bd6c96f1b9eaea31b0119a71b537b7d592164154cde79c695

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Closes #4966

Risk

Medium. It's a small change, but as always, touching account selection is risky as mistakes can mean lost funds.

Testing

Confirm that 1inch quotes now show up when trading between accounts, and that they and sent and received from the correct accounts when executed.

Engineering

Sanity check logic.

Operations

☝️

Screenshots (if applicable)

[gomesalexandre]

Looks sane to me pending runtime testing

[gomesalexandre]

Runtime test - note, I had to bump QUOTE_TIMEOUT_MS up to handle currrent Li.Fi timeouts

Account 0 -> 1 (ERC-20 -> native asset)

• Approve Tx from account 0

• Trade complete account 0 -> 1

Fundus successfully sent to account 1 🎉

Account 0 -> 1 (native asset -> ERC-20)

Note, no approval here as this is a native asset

• Trade complete account 0 -> 1

Note recipient / srcTo where srcTo (the sender) is address zero, which is expected as this is an abstraction when dealing with native assets

Fundus successfully sent to account 1 🎉

Account 1 -> 0 (ERC-20 -> native asset)

• Approve Tx from account 1

Untestable as this is from account 1 which already has allowance granted, and I cannot add the account as account 1 in MM as they use a different account path component for derivation.

• Trade complete account 1 -> 0

Note, had to switch to Gnosisscan for this one as the funds were definitely received (got that sweet Zerion notification for funds received), but Blockscout couldn't pick the XDAI transfer internal Tx 🤦🏽

Fundus successfully sent to account 0 🎉

Account 1 -> 0 (native asset -> ERC-20)

Note, no approval here as this is a native asset

• Trade complete account 1 -> 0

Note recipient / srcTo where srcTo (the sender) is address zero, which is expected as this is an abstraction when dealing with native assets

Fundus successfully sent to account 0 🎉

Account 1 -> 1 as a paranoia regression test

Fundus successfully sent to account 1 🎉

Account 0 -> 0 as a paranoia regression test

Fundus successfully sent to account 1 🎉

[gomesalexandre]

Retest of Account 1 -> 0 (ERC-20 -> native asset), since I noticed this was sent from account 0 (i.e 0 -> 0) in the Tx above.

• Approval step is displayed

• Happy Tx

Two things to note here:

1. While testing this PR, I've noticed these consistently failing:

Not related to this PR per se, but we should never make THOR requests in the first place for e.g. XDAI. Perhaps something to guard against as a follow-up @0xApotheosis ? 🙏🏽

2. WRT the wrong account used above, I believe this has to do with backing off from preview step and going back to input step, though I haven't been able to repro - may have been a one-off shenanigan