-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: free fees for thor holders before tip 014 #8044
Conversation
Copy here is unfortunately wrong. Trades under 1k are already free Updated in 8ea8869 Also removed the link so we don't block the release with the missing link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very nearly good to go, just a few comments and q's before we get this in!
src/components/MultiHopTrade/components/SharedTradeInput/SharedTradeInput.tsx
Show resolved
Hide resolved
src/components/MultiHopTrade/components/MultiHopTradeConfirm/hooks/useTradeExecution.tsx
Show resolved
Hide resolved
Also noticing what looks like an outstanding bug and potential improvement related to Bug: switch wallet does not correctly fetch the new/appropriate voting power for the new wallet. i started with my native wallet and then switched to the frame wallet with test address. after switching the wallet, the discount being applied is still for my native wallet. Improvement: you can start interacting with the trade widget to get quotes immediately and get a quote with fees displayed before the snapshot logic completes. once the snapshot voting power completes, it triggers a refresh of the trade input component and looks weird. seems like we could add a loading state check to keep the quotes displayed, but the fee breakdown loading until voting power fetch is completed and then show (no refresh of state). |
Wallet switch issue: #8058 Loading improvement issue: #8059 |
Description
This is implementing free fees for thor holders before TIP 014 proposal
I don't have enough funds to do a full swap to test if fees are effectively removed, but assuming setting fees to 0 inside
calculateFees
effectively change itI didn't make the votePower slide systemic on purpose as this thing is supposed to stay for a few month and the lift would be a bit more risky, happy to discuss it in a follow up if it bring value
Issue (if applicable)
closes #8019
Risk
Medium, fee calculation could lead user wrongly
Testing
0xC85feF7A1b039A9e080aadf80FF6f1536DADa088
as a spoofed address, to see that trade fees are free because of THOR holding before the proposalnew Date().getFullYear() <= 2025
is true andnew Date().getFullYear() <= 2024
is false to verify if it will be disabled programmaticallyEngineering
n/a
Operations
n/a
Screenshots (if applicable)
Normal account not holding thor > 1000$ trade
Normal account < 1000$ trade
thor holding account > 1000$ trade
thor holding account < 1000$ trade
Banner