-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce snapshot requests number #8057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works!
Though I did notice an issue when adding many accounts, ticket raised here
#8077
Also noticed that voting power for added accounts is not re-fetched until the page is reloaded, which may be fine considering adding an empty one doesn't affect voting power.
Not guranteed to be empty necessarily. They may have skipped accounts and an account loaded later could contain value. Def seems like a follow up improvement to refetch on account add. |
Description
Leverage
scores
endpoint instead ofvp
so we can do only one request for an infinite list of EVM addresses instead of X requests for X accountsIssue (if applicable)
closes #8048
Risk
Medium, snapshot vote power could be buggy
Testing
Engineering
n/a
Operations
n/a
Screenshots (if applicable)
Thor vote power
fox vote power
No discount from thor