fix: reduce snapshot requests number

src/lib/fees/parameters/thorchainLp.ts

@@ -1,5 +1,6 @@
 import type { FeeCurveParameters } from './types'
 
+// THOR asset doesn't have any fee models for now as it's not using curves, we only zero out values to make TS happy with less risks
 const FEE_CURVE_MAX_FEE_BPS = 50 // basis points
 const FEE_CURVE_MIN_FEE_BPS = 20 // basis points
 const FEE_CURVE_NO_FEE_THRESHOLD_USD = 2_000 // usd

src/state/apis/snapshot/getVotingPower.ts

@@ -4,7 +4,7 @@ import axiosRetry from 'axios-retry'
 import type { Strategy } from './validators'
 
 export const getVotingPower = async (
-  address: string,
+  addresses: string[],
   network: string,
   strategies: Strategy[],
   snapshot: number | 'latest',
@@ -26,9 +26,9 @@ export const getVotingPower = async (
   }
   const body = {
     jsonrpc: '2.0',
-    method: 'get_vp',
+    method: 'POST',
     params: {
-      address,
+      addresses,
       network,
       strategies,
       snapshot,
@@ -37,7 +37,7 @@ export const getVotingPower = async (
     },
   }
 
-  const { data } = await axiosWithRetry.post('https://score.snapshot.org', body, {
+  const { data } = await axiosWithRetry.post('https://score.snapshot.org/api/scores', body, {
     headers,
   })
   return data.result

src/state/apis/snapshot/snapshot.ts

@@ -8,13 +8,12 @@ import { BigNumber, bn, bnOrZero } from 'lib/bignumber/bignumber'
 import { FEE_CURVE_PARAMETERS } from 'lib/fees/parameters'
 import type { ParameterModel } from 'lib/fees/parameters/types'
 import { findClosestFoxDiscountDelayBlockNumber } from 'lib/fees/utils'
-import { isFulfilled } from 'lib/utils'
 import type { ReduxState } from 'state/reducer'
 
 import { BASE_RTK_CREATE_API_CONFIG } from '../const'
 import { getVotingPower } from './getVotingPower'
 import type { Proposal, Strategy } from './validators'
-import { ProposalSchema, SnapshotSchema, VotingPowerSchema } from './validators'
+import { ProposalSchema, ScoresSchema, SnapshotSchema } from './validators'
 
 type FoxVotingPowerCryptoBalance = string
 
@@ -165,23 +164,25 @@ export const snapshotApi = createApi({
             FEE_CURVE_PARAMETERS[model].FEE_CURVE_FOX_DISCOUNT_DELAY_HOURS,
           )
           const delegation = false // don't let people delegate for discounts - ambiguous in spec
-          const votingPowerResults = await Promise.allSettled(
-            evmAddresses.map(async address => {
-              const votingPowerUnvalidated = await getVotingPower(
-                address,
-                '1',
-                strategies,
-                foxDiscountBlock,
-                SNAPSHOT_SPACE,
-                delegation,
-              )
-              // vp is FOX in crypto balance
-              return bnOrZero(VotingPowerSchema.parse(votingPowerUnvalidated).vp)
-            }),
+
+          const votingPowerResults = await getVotingPower(
+            evmAddresses,
+            '1',
+            strategies,
+            foxDiscountBlock,
+            SNAPSHOT_SPACE,
+            delegation,
           )
-          const foxHeld = BigNumber.sum(
-            ...votingPowerResults.filter(isFulfilled).map(r => r.value),
-          ).toNumber()
+
+          const scores = ScoresSchema.parse(votingPowerResults).scores
+
+          const foxHeld = scores.reduce((acc: number, scoreByAddress: Record<string, number>) => {
+            const values = Object.values(scoreByAddress)
+
+            if (!values.length) return acc
+
+            return acc + BigNumber.sum(...values.map(bnOrZero)).toNumber()
+          }, 0)
 
           // Return an error tuple in case of an invalid foxHeld value so we don't cache an errored value
           if (isNaN(foxHeld)) {
@@ -190,6 +191,7 @@ export const snapshotApi = createApi({
           }
 
           dispatch(snapshot.actions.setVotingPower({ foxHeld: foxHeld.toString(), model }))
+
           return { data: foxHeld.toString() }
         } catch (e) {
           console.error(e)
@@ -224,23 +226,25 @@ export const snapshotApi = createApi({
             }, new Set()),
           )
           const delegation = false // don't let people delegate for discounts - ambiguous in spec
-          const votingPowerResults = await Promise.allSettled(
-            evmAddresses.map(async address => {
-              const votingPowerUnvalidated = await getVotingPower(
-                address,
-                '1',
-                strategies,
-                THOR_TIP_014_BLOCK_NUMBER,
-                THORSWAP_SNAPSHOT_SPACE,
-                delegation,
-              )
-              // vp is THOR in crypto balance
-              return bnOrZero(VotingPowerSchema.parse(votingPowerUnvalidated).vp)
-            }),
+
+          const votingPowerResults = await getVotingPower(
+            evmAddresses,
+            '1',
+            strategies,
+            THOR_TIP_014_BLOCK_NUMBER,
+            THORSWAP_SNAPSHOT_SPACE,
+            delegation,
           )
-          const thorHeld = BigNumber.sum(
-            ...votingPowerResults.filter(isFulfilled).map(r => r.value),
-          ).toNumber()
+
+          const scores = ScoresSchema.parse(votingPowerResults).scores
+
+          const thorHeld = scores.reduce((acc: number, scoreByAddress: Record<string, number>) => {
+            const values = Object.values(scoreByAddress)
+
+            if (!values.length) return acc
+
+            return acc + BigNumber.sum(...values.map(bnOrZero)).toNumber()
+          }, 0)
 
           // Return an error tuple in case of an invalid thorHeld value so we don't cache an errored value
           if (isNaN(thorHeld)) {

src/state/apis/snapshot/validators.ts

@@ -1,5 +1,5 @@
 import type { Infer } from 'myzod'
-import { array, boolean, keySignature, number, object, string, unknown } from 'myzod'
+import { array, boolean, keySignature, number, object, record, string, unknown } from 'myzod'
 
 const MethodABI = object({
   name: string(),
@@ -80,13 +80,12 @@ export type SnapshotStrategies = Infer<typeof SnapshotSchema>
 
 // ###### voting power
 
-export const VotingPowerSchema = object({
-  vp: number(),
-  vp_by_strategy: array(number()),
-  vp_state: string(),
+export const ScoresSchema = object({
+  state: string(),
+  scores: array(record(number())),
 })
 
-export type VotingPower = Infer<typeof VotingPowerSchema>
+export type VotingPower = Infer<typeof ScoresSchema>
 
 // ###### proposals type