Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use fox as default asset on solana asset pages #8063

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: use fox as default asset on solana asset pages #8063

merged 1 commit into from
Oct 31, 2024

Conversation

kaladinlight
Copy link
Contributor

Description

Another case where solana assets were showing in the trade input component. Use FOX as the default buy asset when on a solana asset page.

Issue (if applicable)

closes #8016

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Ensure solana assets are showing in the trade input component when on a solana asset page
  • Ensure default buy asset behavior is not changed for non solana assets

Engineering

☝️

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

☝️

Screenshots (if applicable)

image

@kaladinlight kaladinlight requested a review from a team as a code owner October 31, 2024 21:43
0xApotheosis
0xApotheosis approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@0xApotheosis 0xApotheosis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gm

Sol not a default asset on the Solana asset route:

Screenshot 2024-11-01 at 10 35 22

Other asset pages work as expected:

Screenshot 2024-11-01 at 10 36 26

@0xApotheosis 0xApotheosis merged commit e5db0c5 into develop Oct 31, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the solana-default-buy-asset branch October 31, 2024 23:36
@0xApotheosis 0xApotheosis mentioned this pull request Nov 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SOL asset available as an option in Swapper with no path
2 participants
@kaladinlight @0xApotheosis